[Player-Owned Ports: Voyage Calculator]

Yeah, I think that's it. The percentage was the only thing I could find that was incorrect, and my numbers are matching now.

 

Thanks so much! :)

 

 

Also, if I were able to come up with a more efficient `calculator` function, could I post a link to it here? I'm working on one, but haven't finished it yet. I'll post run time complexity on both... Just curious. :)

[Player-Owned Ports: Voyage Calculator]

I love this calculator. Thanks so much!

 

However, since the last time it was updated (Feb 13, 2015 apparently), it's not been 100% accurate in its results. After triple checking that all my input is correct, I started looking through the code.

 

Let me first say, WOW that's a lot of variables!!

 

At line 444, you have this:

 

//Bonus %
moraleBonus = 1;
combatBonus = 1;
seafaringBonus = 1;

Then a bunch of if's for each of the different shipwrights. The first thing I noticed was ship #6 (which the select has as "luxurious") says this:

if (shipw == 6)
{
	moraleBonus = 1.05;
	combatBonus = 1.03;
	seafaringBonus = 1.03;
}

That's correct based on the game's description of Luxurious: Boosts ship stats by 3% + Boosts Morale stat by an additional 2%, so

Luxurious = Morale +5%, Combat +3%, Seafaring +3%.

 

However, percentages for numbers 8, 9 and 10 ("Ostentatious", "Battleship", and "Maritime", respectively) appear to be backwards (i added the comments myself):

if (shipw == 8) // ostentatious
{
    moraleBonus = 1.03;
    combatBonus = 1.05;
    seafaringBonus = 1.05;
}
if (shipw == 9) // battleship
{
    moraleBonus = 1.05;
    combatBonus = 1.03;
    seafaringBonus = 1.05;
}
if (shipw == 10) // maritime
{
    moraleBonus = 1.05;
    combatBonus = 1.05;
    seafaringBonus = 1.03;
}

 

Or...

Ostentatious = Morale +3%, Combat +5%, Seafaring +5%.

The problem is, Ostentatious' in game description says "Boosts ship stats by 5% and Morale by and Additional 3%.

 

To me that means:

Ostentatious = Morale +8%, Combat +5%, Seafaring +5%.

 

 

So yeah, just thought i'd point it out :) Thanks again for all the hard work you all do :)

 

(Also, not sure why the colors in the code sections look all weird, sorry about that.)